Develop #94
Merged
Develop #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jamie,
These should fix the FFT issues with OOURA and Accelerate and make the xtract_spectrum output standardised (withDC option correctly flipping whether to include the DC or include the Nyquist).
It also correctly extracts the Nyquist and DC parameters (real only) and when to calculate them.
Tested on Windows (OOURA) and OSX (OOURA and Accelerate) and both work as expected with all memory in xtract_spectrum result being written to.
Plus small fix to xtract_mmbses which caused errors on Windows for malloc.
Nick