Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when collecting launchd data #62

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bartreardon
Copy link

Fix issue when collecting launchd data if a launchd item references a path that no longer exists.

this would previously cause an abort for trying to unwrap an optional

2.2.1 output

Could not cast value of type '__NSArrayM' (0x1f3f28d00) to 'NSString' (0x1f3f24ff0).
zsh: abort      sudo /usr/local/bin/aftermath

For example, a launchd item is created but the bundle/path it refers to is deleted then attempting to generate a sha for the path will fail. This PR updates the string variables so they aren't optionals and protects the attempt to generate a sha behind an if let with an appropriate log if the attempt fails.

… path that no longer exists.

this would previously cause an abort for trying to unwrap an optional

2.2.1 output

```
Could not cast value of type '__NSArrayM' (0x1f3f28d00) to 'NSString' (0x1f3f24ff0).
zsh: abort      sudo /usr/local/bin/aftermath
```
…tionary output (although this does put escape characters in paths, which are still valid, jsut not strictly representing the actual dict value)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant