Make Barrel and HttpCache singletons thread-safe #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses technique described by Jon Skeet here https://csharpindepth.com/articles/singleton#lazy MSDN docs: https://docs.microsoft.com/en-us/dotnet/api/system.lazy-1
|
wouldn't that solve #56 ? |
|
@Redth thoughts? |
|
Would be great to have this merged + published... Just hit issue when attempting to use the current build. Rebuilt with this PR and it worked fin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses technique described by Jon Skeet here https://csharpindepth.com/articles/singleton#lazy
MSDN docs: https://docs.microsoft.com/en-us/dotnet/api/system.lazy-1
I couldn't test this on Android/iOS/macOS because I don't have a Xamarin development environment. Maybe you could test this with your neat Azure pipelines? Though feel free to decline this pull request if testing it would take too much of your time, since these changes usually aren't needed (I have a pretty specific use case where I need the singleton to be thread safe).
E: The tests passed, so I guess it should work?