fix users list appears again if there are multiple users with same name and one of them uses the first name as username #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 19, 2016 19:51
…me and one of them uses the first name as username.
…meter instead of an array
|
If @jakiestfu could merge the code would be great. |
|
This pull request is already 2yrs old, but the Author @jakiestfu seems not responding to anything despite the fact that he is still actively using github. If you want to use this, I created a fork: https://github.com/wisdomsky/Mention.js |
|
@WisdomSky I having issues with At.js because of dot in usernames, like marcos.rocha, so I decided to move to another plugin. If Mention can handle that I will use your fork, but no worry, I will test and give a feedback. Thanks btw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extended fix to @bijanebrahimi's fork.
This commit fixes issue #34.