Fix #1999: default of jakarta.faces.STATE_SAVING_METHOD is "server"

jakartaee · Jan 25, 2025 · ae3329c · ae3329c
1 parent f83ceb0
commit ae3329c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/api/src/main/java/jakarta/faces/annotation/FacesConfig.java b/api/src/main/java/jakarta/faces/annotation/FacesConfig.java
@@ -235,10 +235,10 @@
 
     /**
      * <p class="changed_added_5_0">
-     * Returns {@value StateManager#STATE_SAVING_METHOD_PARAM_NAME} as {@link String} with default of {@link StateSavingMethod#CLIENT}.
+     * Returns {@value StateManager#STATE_SAVING_METHOD_PARAM_NAME} as {@link String} with default of {@link StateSavingMethod#SERVER}.
      * </p>
      */
-    @Nonbinding StateSavingMethod stateSavingMethod() default StateSavingMethod.CLIENT;
+    @Nonbinding StateSavingMethod stateSavingMethod() default StateSavingMethod.SERVER;
 
     /**
      * <p class="changed_added_5_0">
@@ -408,7 +408,7 @@ public char separatorChar() {
 
         @Override
         public StateSavingMethod stateSavingMethod() {
-            return StateSavingMethod.CLIENT;
+            return StateSavingMethod.SERVER;
         }
 
         @Override
@@ -565,7 +565,7 @@ public enum ContextParam {
         SEPARATOR_CHAR(UINamingContainer.SEPARATOR_CHAR_PARAM_NAME, FacesConfig::separatorChar),
 
         /**
-         * Returns {@value StateManager#STATE_SAVING_METHOD_PARAM_NAME} as {@link String} with default of {@link StateSavingMethod#CLIENT}..
+         * Returns {@value StateManager#STATE_SAVING_METHOD_PARAM_NAME} as {@link String} with default of {@link StateSavingMethod#SERVER}..
          * @see StateManager#STATE_SAVING_METHOD_PARAM_NAME
          */
         STATE_SAVING_METHOD(StateManager.STATE_SAVING_METHOD_PARAM_NAME, FacesConfig::stateSavingMethod),

diff --git a/api/src/main/java/jakarta/faces/application/StateManager.java b/api/src/main/java/jakarta/faces/application/StateManager.java
@@ -53,7 +53,7 @@ public abstract class StateManager {
      * </p>
      *
      * <p>
-     * If this parameter is not specified, the default value is {@link StateSavingMethod#CLIENT}
+     * If this parameter is not specified, the default value is {@link StateSavingMethod#SERVER}
      * </p>
      */
     public static final String STATE_SAVING_METHOD_PARAM_NAME = "jakarta.faces.STATE_SAVING_METHOD";
@@ -239,7 +239,7 @@ public void writeState(FacesContext context, Object state) throws IOException {
      */
     public boolean isSavingStateInClient(FacesContext context) {
         if (savingStateInClient == null) {
-            savingStateInClient = ContextParam.STATE_SAVING_METHOD.isDefault(context);
+            savingStateInClient = ContextParam.STATE_SAVING_METHOD.getValue(context) == StateSavingMethod.CLIENT;
         }
         return savingStateInClient;
     }