Skip to content

Commit

Permalink
Remove port parameter
Browse files Browse the repository at this point in the history
even though it was added to the API spec, the parameter is missing from implementation. See Jigsaw-Code/outline-server#1273
  • Loading branch information
jadolg committed Feb 5, 2024
1 parent 3f8459d commit 6e12c00
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
3 changes: 0 additions & 3 deletions outline_vpn/outline_vpn.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ def create_key(
name: str = None,
method: str = None,
password: str = None,
port: int = None,
data_limit: int = None,
) -> OutlineKey:
"""Create a new key"""
Expand All @@ -150,8 +149,6 @@ def create_key(
payload["method"] = method
if password:
payload["password"] = password
if port:
payload["port"] = port
if data_limit:
payload["limit"] = {"bytes": data_limit}

Expand Down
2 changes: 0 additions & 2 deletions test_outline_vpn.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,11 @@ def test_create_key_with_attributes(client: OutlineVPN):
"""Test creating a key with attributes"""
key = client.create_key(
name="Another test key",
port=9090,
data_limit=1024 * 1024 * 20,
method="aes-192-gcm",
password="test",
)
assert key.name == "Another test key"
assert key.port == 9090
assert key.method == "aes-192-gcm"
assert key.password == "test"
assert key.data_limit == 1024 * 1024 * 20
Expand Down

0 comments on commit 6e12c00

Please sign in to comment.