feat: adds check to throw if http status is not 200 (#78)

BREAKING CHANGE

src/index.ts

@@ -58,10 +58,24 @@ async function getPage (url: string, opts: Opts) {
   const contentType = res.headers.get('Content-Type')
   const contentLength = res.headers.get('Content-Length')
 
+  if (res.status !== 200) {
+    throw new UnexpectedError({
+      ...UnexpectedError.BAD_HTTP_STATUS,
+      info: {
+        url,
+        httpStatus: res.status
+      }
+    })
+  }
+
   if (/text\/html|application\/xhtml+xml/.test(contentType) === false) {
     throw new UnexpectedError({
       ...UnexpectedError.EXPECTED_HTML,
-      info: { contentType, contentLength }
+      info: {
+        url,
+        contentType,
+        contentLength
+      }
     })
   }
 

src/unexpectedError.ts

@@ -9,9 +9,15 @@ export default class UnexpectedError extends Error {
     name: 'BAD_OPTIONS'
   }
 
+  static BAD_HTTP_STATUS = {
+    message: 'Error in http request (http status not OK)',
+    name: 'BAD_HTTP_STATUS'
+  }
+
   info: {
     contentLength?: number,
-    contentType?: string
+    contentType?: string,
+    httpStatus?: string
   }
 
   constructor (errorType: { message: string, name: string, info? }) {

test/basic/test.ts

@@ -1,7 +1,7 @@
 import { unfurl } from '../../src/'
 import nock from 'nock'
 
-test('should handle content which is excaped badly', async () => {
+test('should handle content which is escaped badly', async () => {
   nock('http://localhost')
     .get('/html/double-escaped-edge-case')
     .replyWithFile(200, __dirname + '/double escaped-edge-case.html', {

test/encoding/test.ts

@@ -8,8 +8,6 @@ test('should detect GB2312 charset (HTML 4) and convert to UTF-8', async () => {
     .get('/html4/gb2312')
     .replyWithFile(200, __dirname + '/html_4.html', { 'Content-Type': 'text/html' })
 
-    // require('http').get('http://localhost/html4/gb2312', console.log)
-
   const result = await unfurl('http://localhost/html4/gb2312')
 
   const expected = {

test/general/status-code.test.ts

@@ -0,0 +1,26 @@
+import { unfurl } from '../../src'
+import nock from 'nock'
+import UnexpectedError from '../../src/unexpectedError'
+
+test('should throw if status code not 200', () => {
+  nock('http://localhost')
+    .get('/html/return-404')
+    .reply(404)
+
+  return expect(unfurl('http://localhost/html/return-404'))
+    .rejects
+    .toThrow(new UnexpectedError(UnexpectedError.BAD_HTTP_STATUS))
+})
+
+test('should not throw if status code is 200', async () => {
+  nock('http://localhost')
+    .get('/html/return-200')
+    .reply(200, '', {
+      'Content-Type': 'text/html'
+    })
+
+  return expect(unfurl('http://localhost/html/return-200'))
+    .resolves
+    .toBeTruthy()
+})
+