Add the ability to listen on UNIX sockets

[Caian]

This is a continuation of #2111 that was closed.

As stated in the original PR, using unix sockets can have a beneficial impact on performance. I found that particularly relevant when running my invidious instance in a rootless container.

This PR adds the socket_binding option to config that specifies a socket to listen to. The socket_binding option will disable listening to TCP. I also added socket_permissions because often one needs to control who accesses the socket.

[Caian]

Tested and running on my personal invidious behind a Caddy proxy with https enabled. Now videojs buffers the video much faster and the user-mode networking on the server consumes a less CPU and RAM.

[unixfox]

Maybe you can combine the two parameters into one.

And make sure to comment them otherwise socket binding will be on by default!

[Caian]

Maybe you can combine the two parameters into one.

And make sure to comment them otherwise socket binding will be on by default!

Ops, I fixed the configuration file to leave it disable. I prefer the idea of leaving separate parameters for clarity, but if the parameters were to be combined I was thinking of doing something like:

socket_binding: /tmp/invidious.socket,777

What do you think?

[unixfox]

Maybe you can combine the two parameters into one.

And make sure to comment them otherwise socket binding will be on by default!

Ops, I fixed the configuration file to leave it disable. I prefer the idea of leaving separate parameters for clarity, but if the parameters were to be combined I was thinking of doing something like:

socket_binding: /tmp/invidious.socket,777

What do you think?

You can also do it this way:

socket_binding:
path: /tmp/invidious.socket
permission: 777

[Caian]

Maybe you can combine the two parameters into one.
And make sure to comment them otherwise socket binding will be on by default!

Ops, I fixed the configuration file to leave it disable. I prefer the idea of leaving separate parameters for clarity, but if the parameters were to be combined I was thinking of doing something like:
socket_binding: /tmp/invidious.socket,777
What do you think?

You can also do it this way:

socket_binding: path: /tmp/invidious.socket permission: 777

I like this solution, implemented.

[unixfox]

don't modify the other parameters please.

[Caian]

Sorry I'll revert that, my editor automatically removed a trailing space...

[unixfox]

Maybe you could add some sort of checks. Like is the path correctly configured. And if the permission parameter entered are correct (numbers + is it a valid combination of numbers)

There are some examples here: https://github.com/iv-org/invidious/blob/master/src/invidious/config.cr#L225-L233

[Caian]

Sure, I'll take a look!