Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send query string instead of range http header #5087

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

unixfox
Copy link
Member

@unixfox unixfox commented Nov 20, 2024

Send the range using query string like the YouTube player do.

This avoids having to do some processing inside Invidious and just straight send the correct query string to YouTube servers.

Makes it easier to be compatible with other videoplayback proxies like http3-ytproxy or piped-proxy. Especially the last one because piped only use query string now for the range.

Copied from https://github.com/FreeTubeApp/FreeTube/blob/540a5a9385859d855a5989467323414d16470d8a/src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js#L1101-L1103

@unixfox unixfox requested a review from a team as a code owner November 20, 2024 14:25
@unixfox unixfox requested review from SamantazFox and syeopite and removed request for a team November 20, 2024 14:25
@absidue
Copy link
Contributor

absidue commented Nov 21, 2024

Last time I tested this it didn't work with Invidious' own video proxy, which is why FreeTube still sends the range header instead of the query parameter to Invidious. I haven't tested this specific pull request though, so maybe it is different with this one.

@SamantazFox
Copy link
Member

This avoids having to do some processing inside Invidious and just straight send the correct query string to YouTube servers.

Invidious will always need some client-side processing for clients with JS disabled

@unixfox
Copy link
Member Author

unixfox commented Dec 10, 2024

This avoids having to do some processing inside Invidious and just straight send the correct query string to YouTube servers.

Invidious will always need some client-side processing for clients with JS disabled

True but at least for most people there is no processing involved. Same for the ones using DASH.

On a public instance it's much welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants