Remove deprecated flag from mc-image-helper command in start-setupRbac

[augustabt]

The --append-only flag was removed from mc-image-helper manage-users in commit 5fbfd0e. If APPEND_WHITELIST or OVERRIDE_WHITELIST are set to false the container fails to start. As far as I can tell it is safe to simply remove the section since if neither variable is set to true the script defaults to --existing=MERGE which is the desired behavior.

[itzg]

Thanks for working on a fix for this. I think accidentally forgot to do the same as APPEND_OPS and OVERRIDE_OPS here:

docker-minecraft-server/scripts/start-setupRbac

Lines 50 to 57 in 26d97c2

	# legacy option
	if [[ -v APPEND_OPS ]] && isTrue "${APPEND_OPS}"; then
	existing=MERGE
	fi
	# legacy option
	if [[ -v OVERRIDE_OPS ]] && isFalse "${OVERRIDE_OPS}"; then
	existing=SKIP
	fi

Can you try out a change similar to that?

The removal is good too since those are long now legacy variables.