Convert check_ref_format to class method #283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the check_ref_format function in dulwich/__init__.py to a class method for more flexibility and to allow calling it without instantiating the class. This simplifies the usage of this method while maintaining existing functionality. More context for this is at iterative/studio#8187 (comment)
|
If we want to make this a classmethod, it should be a classmethod in the base backend abstract class and in all of the implementations, and top level But honestly IMO it's not a problem for studio to just call |
Adjusted the formatting and indentation of several blocks of code across the files git/backend/gitpython.py, git/backend/pygit2/__init__.py, and git/backend/base.py to increase readability and maintain code cleanliness. Also, refactored the 'check_ref_format' function in git/backend/gitpython.py and git/backend/base.py to be a class method, thus allowing it to be called without an instance of the class. This change allows for more flexibility when using this method, while still preserving its original functionality.
|
Closing this for now. @shcheklein Feel free to takeover if you think this is necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the check_ref_format function in dulwich/init.py to a class method for more flexibility and to allow calling it without instantiating the class. This simplifies the usage of this method while maintaining existing functionality.
More context for this is at https://github.com/iterative/studio/pull/8187#issuecomment-1804589654