Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing library "overtrue_wechat" #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix missing library "overtrue_wechat" #7

wants to merge 3 commits into from

Conversation

ranqiangjun
Copy link

There is no autoload.php included in overture/wechat now, we should use composer to generate one.

@ranqiangjun ranqiangjun changed the title Fix #6 Fix Missing library "overtrue_wechat" Dec 1, 2016
@ranqiangjun ranqiangjun changed the title Fix Missing library "overtrue_wechat" Fix missing library "overtrue_wechat" Dec 1, 2016
@ranqiangjun
Copy link
Author

And, if it is ok, please add me a maintainer of this sandbox project. I'd like to have a try to promote this project to a full project such as https://www.drupal.org/project/commerce_wechatpay.

Thanks the IT Consultis guys for contributing this awesome module to the community!

@ranqiangjun
Copy link
Author

BTW, my profile on drupal.org is https://www.drupal.org/u/jungle.

@tguillemaud
Copy link

Hi Jungle,

Sorry I missed your PR. We will review it in detail tomorrow. In the meantime, I added you as a user on the sandbox.

Cheers,

@ranqiangjun
Copy link
Author

Thanks @tguillemaud. I checked that I can promote it as a full project now on Drupal.org.

As you know, once a project is promoted, it can not be turned back into a sandbox.

So do you or IT Consultis want this project to be promoted?

And if the answer is yes, is the short name of this project still commerce_wechatpay?

@tguillemaud
Copy link

Hi @ranqiangjun

No problem to promote it if we keep some control on it and that we are credited. I'm fine with the name :)

Thanks

@ranqiangjun
Copy link
Author

Hi @tguillemaud, it's a full project now. In addition to the sandbox project became a full project, nothing changed. It is still under the full control of the original author who created it.

Here is the new URL: https://www.drupal.org/project/commerce_wechatpay

@freedomgao
Copy link
Contributor

Hi @ranqiangjun, I used your change still not working, we need use overtrue/wechat that version have to less than 3.0, if use new version we need rewrite this module.

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants