added ssh option 'keys_only: true' when not using password login issue #232 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ref: #232 |
ryotarai
requested changes
Dec 2, 2016
| @@ -257,6 +257,8 @@ def ssh_options | |||
| password = STDIN.noecho(&:gets).strip | |||
| print "\n" | |||
| opts.merge!(password: password) | |||
| else | |||
| opts.merge!(keys_only: true) | |||
There was a problem hiding this comment.
Please set keys_only: true only if @options[:key] is set.
There was a problem hiding this comment.
Hi, @ryotarai, this is going to work when setting the key via command line but it is going to fail when the key is set by ssh config.
Is this the intended behaviour?
added 2 commits
December 4, 2016 21:29
ryotarai
requested changes
Dec 28, 2016
| @@ -257,6 +257,8 @@ def ssh_options | |||
| password = STDIN.noecho(&:gets).strip | |||
| print "\n" | |||
| opts.merge!(password: password) | |||
| else | |||
| opts.merge!(keys_only: true) if @options[:key] | |||
There was a problem hiding this comment.
[nits] opts[:keys] is better than @options[:key] in this context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://net-ssh.github.io/ssh/v2/api/classes/Net/SSH.html
:keys_only => set to true to use only private keys from keys and key_data parameters, even if ssh-agent offers more identities. This option is intended for situations where ssh-agent offers many different identites.