Poetry #179
Merged
Poetry #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @peppelinux , the Dockerfile don't install poetry, work with old method: Lines 29 to 32 in 5a424ee Could you have missed a commit? |
|
@peppelinux other question, with env in poetry I have some problem: poetry env is readed But fail the poetry dependance installation: This can be a system problem, I need to study this problem |
|
yeah, weird |
|
@peppelinux , simplified poetry dockerfile (start from python-xx-alpine): FROM python:3.13-alpine
# Metadata params
ARG BUILD_DATE
ARG VERSION
ARG VCS_URL="https://github.com/italia/iam-proxy-italia.git"
ARG VCS_REF
ARG AUTHORS
ARG VENDOR
# Metadata : https://github.com/opencontainers/image-spec/blob/main/annotations.md
LABEL org.opencontainers.image.authors=$AUTHORS \
org.opencontainers.image.vendor=$VENDOR \
org.opencontainers.image.title="iam-proxy-italia" \
org.opencontainers.image.created=$BUILD_DATE \
org.opencontainers.image.version=$VERSION \
org.opencontainers.image.source=$VCS_URL \
org.opencontainers.image.revision=$VCS_REF \
org.opencontainers.image.description="Docker Image di iam-proxy-italia."
RUN apk add --update --no-cache tzdata mailcap poetry
WORKDIR /satosa_proxy
ADD poetry.lock pyproject.toml ./
RUN poetry lock && poetry installP.S. must be add |
|
This PR must use a static venv path, according to the requirement shown below |
We can add FROM python:3.13-alpine
# Metadata params
ARG BUILD_DATE
ARG VERSION
ARG VCS_URL="https://github.com/italia/iam-proxy-italia.git"
ARG VCS_REF
ARG AUTHORS
ARG VENDOR
# Metadata : https://github.com/opencontainers/image-spec/blob/main/annotations.md
LABEL org.opencontainers.image.authors=$AUTHORS \
org.opencontainers.image.vendor=$VENDOR \
org.opencontainers.image.title="iam-proxy-italia" \
org.opencontainers.image.created=$BUILD_DATE \
org.opencontainers.image.version=$VERSION \
org.opencontainers.image.source=$VCS_URL \
org.opencontainers.image.revision=$VCS_REF \
org.opencontainers.image.description="Docker Image di iam-proxy-italia."
RUN apk add --update --no-cache tzdata mailcap poetry
RUN poetry config virtualenvs.in-project true
ADD poetry.lock pyproject.toml /
RUN poetry lock && poetry install
WORKDIR /satosa_proxyNow I'm in train, when have a good internet connection I try |
|
@MdreW I have fixed all the issues, including the one about poetry and several other deprecations and stuffs foudn in a total state of regression |
MdreW
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR switches from virtualenv and pip to poetry