Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "fix" script, converted buffers to strings, updated snapshot #1556

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 16
registry-url: 'https://external-dot-oss-automation.appspot.com'
cache: npm
if: ${{ steps.release.outputs.release_created }}
- run: npm publish
Expand Down
49 changes: 40 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"pretest": "npm run lint && npm run clean && npm run instrument",
"test": "tap",
"snap": "npm test -- --snapshot",
"fix": "standard --fix",
"posttest": "npm run report",
"clean": "node ./npm-run-clean.js",
"instrument": "node ./build-self-coverage.js",
Expand Down Expand Up @@ -68,7 +69,7 @@
"glob": "^7.1.6",
"istanbul-lib-coverage": "^3.0.0",
"istanbul-lib-hook": "^3.0.0",
"istanbul-lib-instrument": "^4.0.0",
"istanbul-lib-instrument": "^6.0.2",
"istanbul-lib-processinfo": "^2.0.2",
"istanbul-lib-report": "^3.0.0",
"istanbul-lib-source-maps": "^4.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tap-snapshots/test/nyc-integration.js.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -888,7 +888,7 @@ exports[`test/nyc-integration.js > TAP > passes configuration via environment va
`

exports[`test/nyc-integration.js > TAP > recursive run does not throw > stdout 1`] = `

Buffer <2268 656c 6c6f 220d 0a "hello"..>
`

exports[`test/nyc-integration.js > TAP > report and check should show coverage check along with report > stderr 1`] = `
Expand Down
4 changes: 2 additions & 2 deletions test/helpers/run-nyc.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ async function runNYC ({ args, tempDir, leavePathSep, cwd = fixturesCLI, env = {
stderr,
stdout
},
stderr: sanitizeString(stderr, cwd, leavePathSep),
stdout: sanitizeString(stdout, cwd, leavePathSep)
stderr: sanitizeString(stderr.toString('utf8'), cwd, leavePathSep),
stdout: sanitizeString(stdout.toString('utf8'), cwd, leavePathSep)
}
}

Expand Down
1 change: 0 additions & 1 deletion test/helpers/test-success.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ async function testSuccess (t, opts) {

t.equal(status, 0)
t.equal(stderr, '')
console.info(stdout)
t.matchSnapshot(stdout, 'stdout')
}

Expand Down
3 changes: 2 additions & 1 deletion test/nyc-integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,8 @@ t.test('recursive run does not throw', t => testSuccess(t, {
nycBin,
process.execPath,
nycBin,
'true'
'echo',
'hello'
],
cwd: path.resolve(__dirname, 'fixtures/recursive-run')
}))
Expand Down
Loading