Implement FUN_10025720() and others
#1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxtacles
reviewed
Nov 4, 2024
jonschz
commented
Nov 5, 2024
| break; | ||
| case 6: | ||
| m_unk0x10a = g_unk0x100d65b0[Beta0x10070520()].m_unk0x18; | ||
| uVar6 = m_unk0x10a; |
There was a problem hiding this comment.
Removing uVar6 here does decrease the match percentage, but I find its use confusing. Maybe there is an inline function that originally took an MxS32. Hard to tell because BETA10 does not have this part at all.
Edit: I tried the inline function and I can't get it to 100 % in an obvious way. Let's probably leave it the way it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FUN_10025720matches up to one minor detail, the rest matches to 100 %.