Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UnknownMx4DPointFloat::FUN_100040a0 #1102

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

jonschz
Copy link
Contributor

@jonschz jonschz commented Sep 8, 2024

This one was quite annoying and I didn't get it to match as well as I hoped, but I still think it is an improvement. I would greatly appreciate if someone else took a look as well.

I tried to match FUN_100040a0 to BETA10 and found a number of corrections there, bringing it up to 91.4 %. LEGO1 might be down to compiler entropy, but I am not sure.

One extremely annoying thing I noticed is that the BETA10 compilation depends on the names of variables, even if they are unused.

@disinvite
Copy link
Contributor

One extremely annoying thing I noticed is that the BETA10 compilation depends on the names of variables, even if they are unused.

Is that what determines the stack order?

@jonschz
Copy link
Contributor Author

jonschz commented Sep 8, 2024

I didn't figure out the entire pattern so I can't say anything for certain, but I can say for sure that the mere act of renaming a variable did at least influence the stack order (I tried a couple of names for the variables I ultimately named a and b). I guess there are other factors on the stack order as well (like the scope of the variable, when and where are they first used, ...).

@foxtacles
Copy link
Member

foxtacles commented Sep 9, 2024

Looks good to me! I'll give it another look later this week but it's an improvement for sure

@foxtacles foxtacles merged commit 5d19b6a into isledecomp:master Sep 9, 2024
16 checks passed
@jonschz jonschz deleted the improve-FUN_100040a0 branch September 15, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants