Minor tweak to MxList template

[disinvite]

This is a very small code change bundled with a huge number of beta addresses for MxList and related template classes.

Prior to this change, these functions call DeleteAll on an MxList¹:

• LegoWorld::Destroy
• MxDSMultiAction::CopyFrom
• MxDSSelectAction::CopyFrom
• MxDSSelectAction::Deserialize
• MxRegion::Reset
• MxCompositePresenter::EndAction

MxCompositePresenter::EndAction is a special case; it is the only one of these that skips destroying the values for each entry in the list. The optional parameter has a default of TRUE, but we use FALSE explicitly here.

The beta shows that these are two different functions and no parameter is passed. It doesn't seem to be a case where the destroy-or-not option is part of the template, because MxCompositePresenter calls the same functions on MxList<MxDSAction *> as other functions that use this list. I changed DeleteAll() and the new function Empty() so the for-loop matches the beta.

The functions that call DeleteAll() or Empty() appear unaffected, but this change generated the usual noise to other functions. Setting the m_first and m_last members to null in one line matched the beta but generated no diff in retail.

Other stuff:

The beta supports a change to the Next and Prev functions of MxListCursor where the if-block is reversed, but this drops accuracy across the board so I left it alone. i.e.:

// Retail (how it is now)
if (!m_match) {
    m_match = m_list->m_first;
}
else {
    m_match = m_match->GetNext();
}

// Beta
if (m_match) {
    m_match = m_match->GetNext();
}
else {
    m_match = m_list->m_first;
}

There's a note in mxregionlist.h about the MxRegionTopBottomListCursor constructor. I couldn't find any clear evidence that this should be MxRegionTopBottomList versus MxPtrList<MxRegionTopBottom>*, but the addrs are there so we can take another look.

Footnotes

1. Each MxList destructor also calls DeleteAll. ↩