-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[irssi_logger.pl] added a blacklist option, added host and port as new options #853
Conversation
question if the blacklist should be changeable without having to save and reload the script? |
general remark: version needs to be increased |
i dunno how. lemme go read another script and fix that. |
scripts/irssi_logger.pl
Outdated
} | ||
|
||
sub write_db { | ||
my ($nick, $message, $target) = @_; | ||
my @vals; | ||
my $date = strftime("%Y-%m-%d %H:%M:%S", localtime); | ||
if (exists $blacklist{$target}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, i'd just do an if (!exists
here and exclude the } else {
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Like the title says, added a blacklist, host and port option.
tested with postgres 15.4 and 14.2 .