[irssi_logger.pl] added a blacklist option, added host and port as new options #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailin-nemui
changed the title
|
question if the blacklist should be changeable without having to save and reload the script? |
|
general remark: version needs to be increased |
|
i dunno how. lemme go read another script and fix that. |
qbit
reviewed
Aug 22, 2023
scripts/irssi_logger.pl
Outdated
| } | ||
|
|
||
| sub write_db { | ||
| my ($nick, $message, $target) = @_; | ||
| my @vals; | ||
| my $date = strftime("%Y-%m-%d %H:%M:%S", localtime); | ||
| if (exists $blacklist{$target}) { |
There was a problem hiding this comment.
Personally, i'd just do an if (!exists here and exclude the } else {.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the title says, added a blacklist, host and port option.
tested with postgres 15.4 and 14.2 .