[Substrait] Simplify assembly format of field_reference op.
#849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpienaar
approved these changes
Jul 22, 2024
This PR removes a pair of `[.]` around the integer array `position` attribute of the `field_reference` op, which isn't necessary. The original format had used the additional pair of brackets out of ignorance and was misleading as it suggested that there is an additional nesting level, which actually doesn't exist. Signed-off-by: Ingo Müller <[email protected]>
ingomueller-net
force-pushed
the
substrait-ref-assembly
branch
from
96c3f93
to
2951f32
Compare
ingomueller-net
added a commit
to ingomueller-net/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
…rg/iree-llvm-sandbox#849) This PR removes a pair of `[.]` around the integer array `position` attribute of the `field_reference` op, which isn't necessary. The original format had used the additional pair of brackets out of ignorance and was misleading as it suggested that there is an additional nesting level, which actually doesn't exist. Signed-off-by: Ingo Müller <[email protected]>
ingomueller-net
added a commit
to ingomueller-net/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
…rg/iree-llvm-sandbox#849) This PR removes a pair of `[.]` around the integer array `position` attribute of the `field_reference` op, which isn't necessary. The original format had used the additional pair of brackets out of ignorance and was misleading as it suggested that there is an additional nesting level, which actually doesn't exist. Signed-off-by: Ingo Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on and, therefor, includes #848.
@albertcohen: Thanks for suggesting!
This PR removes a pair of
[.]around the integer arraypositionattribute of the
field_referenceop, which isn't necessary. Theoriginal format had used the additional pair of brackets out of
ignorance and was misleading as it suggested that there is an additional
nesting level, which actually doesn't exist.