-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Substrait] Add pattern removing duplicate yields in project. #846
Merged
ingomueller-net
merged 1 commit into
iree-org:main
from
ingomueller-net:substrait-emit-deduplication-project-yield
Jul 23, 2024
Merged
[Substrait] Add pattern removing duplicate yields in project. #846
ingomueller-net
merged 1 commit into
iree-org:main
from
ingomueller-net:substrait-emit-deduplication-project-yield
Jul 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
force-pushed
the
substrait-emit-deduplication-project-yield
branch
2 times, most recently
from
May 31, 2024 12:17
bb7e222
to
ccddb3c
Compare
jpienaar
approved these changes
Jul 22, 2024
MLIRContext *context = op.getContext(); | ||
Operation *terminator = op.getExpressions().front().getTerminator(); | ||
int64_t numOriginalYields = terminator->getNumOperands(); | ||
auto inputTupleType = cast<TupleType>(op.getInput().getType()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this is verified for ProjectOp that it has only TupleType inputs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ingomueller-net
force-pushed
the
substrait-emit-deduplication-project-yield
branch
from
July 23, 2024 13:00
ccddb3c
to
8d61245
Compare
This PR adds a pattern to the emit deduplication pass that removes duplicates introduced by the `project` op by yielding values more than once. Signed-off-by: Ingo Müller <[email protected]>
ingomueller-net
force-pushed
the
substrait-emit-deduplication-project-yield
branch
from
July 23, 2024 13:08
8d61245
to
7b3ca6d
Compare
ingomueller-net
added a commit
to ingomueller-net/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
…-org/iree-llvm-sandbox#846) This PR adds a pattern to the emit deduplication pass that removes duplicates introduced by the `project` op by yielding values more than once. Signed-off-by: Ingo Müller <[email protected]>
ingomueller-net
added a commit
to ingomueller-net/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
…-org/iree-llvm-sandbox#846) This PR adds a pattern to the emit deduplication pass that removes duplicates introduced by the `project` op by yielding values more than once. Signed-off-by: Ingo Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on and, therefor, includes #836 and its dependencies.This PR adds a pattern to the emit deduplication pass that removes
duplicates introduced by the
project
op by yielding values more thanonce.