-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Substrait] Implement simple extensions.
This is a mechanism of Substrait to define functions and types external to the core specification. This PR models the declarations as `Symbol`s and references to them as symbol references in MLIR, which allows to use MLIR tooling around symbols (such as `SymbolTable`s, iterating over symbol uses, code navigation via the LSP server, etc.). The PR does not yet implement a mechanism to use the functions and types, which subsequent PRs for `ScalarFunction` and similar are going to do. While touching the `PlanOp`-related test cases, this op also merges the tests of that op, which were previously split into a "simple" and a "version" file, which probably predates the possibility to tell `mlir-translate` (and custom variants) to use output splitters. Signed-off-by: Ingo Müller <[email protected]>
- Loading branch information
1 parent
b705bd5
commit 662a78d
Showing
12 changed files
with
742 additions
and
196 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.