add array support for secrecy #1239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -258,6 +275,8 @@ impl CloneableSecret for u64 {} | |||
| impl CloneableSecret for u128 {} | |||
| impl CloneableSecret for usize {} | |||
|
|
|||
| impl<const N: usize, T> CloneableSecret for [T; N] where T: CloneableSecret {} | |||
There was a problem hiding this comment.
I opened #1245 with just this since it's uncontroversial
Comment on lines
+216
to
+224
| impl<S, const N: usize> From<[S; N]> for SecretArray<S, N> | ||
| where | ||
| S: Zeroize, | ||
| [S; N]: Zeroize, | ||
| { | ||
| fn from(array: [S; N]) -> Self { | ||
| Self::from(Box::new(array)) | ||
| } | ||
| } |
There was a problem hiding this comment.
This has various issues which are a little bit concerning:
- it's moving the array instead of taking a reference, which may make a copy
- it's sidestepping the constructors which otherwise exist for
SecretBoxwhich go out of the way to avoid leaving copies on the stack
The big difference between this and SecretSlice/SecretString is those types are ultimately heap-backed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some code where we are using fixed length arrays and would like for those to remain secret. This PR adds the ability to do the following
Adds the ability to use
[S; N]as a secret. Notably,CloneableSecretwas not implemented for[S; N]Adds a new helper type called
SecretArraythat is justSecretBox<[S; N]>