Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use separate logger for service worker #98

Closed
wants to merge 2 commits into from

Conversation

2color
Copy link
Member

@2color 2color commented Mar 11, 2024

Description

This PR creates a separate logger instance for the service worker to make it a bit easier for debugging and avoid needing to prefix the log messages in the service worker.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)

@2color 2color requested a review from SgtPooki March 11, 2024 13:30
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have some functions that are used by the UI and the sw that both use the logger, so we will likely need to pass through a logger option to those methods so the right log prefix is used

@2color 2color closed this Mar 22, 2024
@2color
Copy link
Member Author

2color commented Mar 22, 2024

Closed in favour of a different approach discussed in-person where we:

See #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants