feat: support ens resolution #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
commented
Feb 27, 2024
| @@ -126,7 +129,12 @@ function changeCssFontPath (path: string): string { | |||
| * | |||
| */ | |||
| export async function heliaFetch ({ path, helia, signal, headers, id, protocol }: HeliaFetchOptions): Promise<Response> { | |||
There was a problem hiding this comment.
we should remove helia here and the get-helia since we can't pass both custom dnsResolvers and a custom helia instance.
until either cloudflare or delegated-ipfs.dev dns-query is working, this is working for ens resolution
|
ens resolution is working with the last RC version of verified-fetch and the config from https://github.com/ipshipyard/waterworks-infra/pull/30 deployed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Description
Adds cloudflare ens resolver (which falls back to regular dns resolution) and updates verified-fetch to the latest RC.
fixes #23
Notes & open questions
SHOULD NOT BE MERGED because cloudflare is still failing CORS. See ipshipyard/waterworks-community#6 (comment)
Change checklist