-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): additional pin to scaleway #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Low risk, so I'm going to merge this.
Some comments inline with hopefully useful info.
- name: Pin to Scaleway | ||
if: ${{ steps.scaleway.outputs.existing-pin == '' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ Skipping on any preexisting pins for the CID before pinning it again to avoid HTTP 409 error due to duplicate pin. It would often happen in main
branch when ./dist
output does not change (e.g. commits with docs edits).
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/css/tachyons.min.css" integrity="sha256-MgEf5i1a74lVzhT+1R6mBbWCUeUaxC8sQTaN5GY+CoI=" crossorigin="anonymous"> | ||
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/ipfs.css" integrity="sha256-tlU/gvVvLjSbTOfSZyCzuQxY8QcmHPtJJ1oTXilA9gk=" crossorigin="anonymous"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ I needed to produce new ./dist
for testing, so switched to SRI + jsdelivr here.
<!-- | ||
|
||
This HTML page initializes IPFS Service Worker Gateway. | ||
|
||
The HTTP server behind this HTTP URL does not host this website. | ||
Instead, it sends basic website code along with JavaScript. The JS sets | ||
up a tool called IPFS Service Worker Gateway in the user's browser and | ||
uses JavaScript version of IPFS (https://helia.io/) to get IPFS blocks | ||
from content providers. | ||
|
||
CID hash verification and data assembly happens in the browser. | ||
|
||
Learn more about it here: https://github.com/ipfs-shipyard/helia-service-worker-gateway | ||
|
||
--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ @2color fysa added this disclaimer for curl/cli devs and users expecting deserialized payload, feel free to adjust in follow-up PR.
Similar to #105, pins to
pl-waw.ipfs.labs.scw.cloud
using remote pinning API.Some thoughts on Scaleway as pinning service
--cid
filtering onipfs pin remote
commands does not work correctly, seems to be ignored by Scaleway.--name
works, so just putting CID there to allow us skip pinning if CID is already pinned (example). 🤷Still, was easy to make it work, is fast, and gives us another copy.
I am going to merge this to increase our ability to dogfood setup with more than two pinning services.
Once merged, we will have three ways of pinning remotely, which is great for dogfooding, and evaluating complexity/maintenance/stability/cost:
ipfs-cluster-ctl
CLIipfs pin remote
/ pinning-services-api-spec