Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process Improvement: v0.18.0 #9484

Merged
merged 25 commits into from
Mar 27, 2023
Merged

Process Improvement: v0.18.0 #9484

merged 25 commits into from
Mar 27, 2023

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Dec 8, 2022

Related to #9417

This PR is to track the process improvement as identified during the v0.18.0 release.

The new version of the release issue template available at https://github.com/ipfs/kubo/blob/process-improvement-v0.18.0/docs/RELEASE_ISSUE_TEMPLATE.md

@galargh galargh mentioned this pull request Dec 8, 2022
@galargh galargh self-assigned this Jan 2, 2023
@BigLep
Copy link
Contributor

BigLep commented Jan 4, 2023

For the Bifrost gateway deployment, it's probably worth adding a pointer to Bifrost's docs: https://www.notion.so/pl-strflt/Kubo-Gateway-Release-Notes-6e0efff28ee540be9ccb8f2b85104c42

@BigLep
Copy link
Contributor

BigLep commented Jan 12, 2023

I think we should add a post-release step for creating the PR that updates our dependencies. As long as the PR gets created and linked to the the next release, we are good. Something like:

- [ ] Initiate dependence update
   - [ ] Run X to update all dependencies and create PR (example)
   - [ ] Link new PR to next release issue that was created above

@BigLep
Copy link
Contributor

BigLep commented Jan 26, 2023

I noticed that https://github.com/ipfs/kubo/blob/master/docs/changelogs/v0.18.md doesn't include contributors or changelog filled in.

@galargh
Copy link
Contributor Author

galargh commented Jan 26, 2023

I noticed that https://github.com/ipfs/kubo/blob/master/docs/changelogs/v0.18.md doesn't include contributors or changelog filled in.

I'm a bit confused. Looks to me like it has both. Is it possible you loaded the page before #9581 was merged?

@BigLep
Copy link
Contributor

BigLep commented Jan 26, 2023

@galargh : doh - my bad. I think I must have been looking at the file in a branch before #9581 was merged! Thanks!

@galargh
Copy link
Contributor Author

galargh commented Jan 26, 2023

I'm going to test the new instructions on the v0.18.1 (since I'm proposing to merge the regular and patch release instructions in this pr; with only a couple of excluded steps for patch) and then I'm going to mark this as ready for review.

@galargh galargh mentioned this pull request Jan 31, 2023
@galargh
Copy link
Contributor Author

galargh commented Jan 31, 2023

The release instructions tested during v0.18.1: https://github.com/ipfs/kubo/blob/process-improvement-v0.18.0/docs/RELEASE_ISSUE_TEMPLATE.md

@galargh galargh marked this pull request as ready for review January 31, 2023 15:13
@galargh galargh mentioned this pull request Mar 6, 2023
@galargh
Copy link
Contributor Author

galargh commented Mar 21, 2023

@BigLep We tested these instructions during v0.19.0. Let me know if you're OK with merging this now.

Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go through the latest line by line, but no doubt this is an improvement on what is there. Further adjustment can be made in future if/as needed.

@galargh galargh merged commit bf7d0fc into master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants