Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LICENSE-APACHE #9212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

RubenKelevra
Copy link
Contributor

Just an update from the small disclaimer usually meant for console output etc. to the full license text

Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BigLep
Copy link
Contributor

BigLep commented Aug 26, 2022

2022-08-26 triage note: @TMoMoreau will take this on.

@TMoMoreau
Copy link
Contributor

Just as a heads up, that is the wrong tmo you tagged :) @BigLep

@RubenKelevra
Copy link
Contributor Author

Lets replace this with https://github.com/ipfs/ipfs-repository-template/blob/main/LICENSE.md instead.

Specific actions:

  1. Remove https://github.com/ipfs/kubo/blob/master/LICENSE-APACHE
  2. Remove https://github.com/ipfs/kubo/blob/master/LICENSE-MIT
  3. Copy in the content of https://github.com/ipfs/ipfs-repository-template/blob/main/LICENSE.md to https://github.com/ipfs/kubo/blob/master/LICENSE but leave the transitionary text (https://github.com/ipfs/kubo/blob/master/LICENSE#L1-L5 ) at the top.

That could be a new PR and we close this one.

Well, the downside of doing this is, that Github will continue to show an "unknown license" on the right side, like now.

To avoid this I like to add the licenses exactly how Github shows them.

The "LICENSE" could be removed and the text just added to the readme for example.

@RubenKelevra
Copy link
Contributor Author

Here's how this looks like:

IMG_20220826_183630.jpg

@Jorropo
Copy link
Contributor

Jorropo commented Aug 26, 2022

@RubenKelevra then someone should fix the template.

We don't want to have kubo doing a snowflake solution, if there is an issue it should be fixed in the template.

@RubenKelevra
Copy link
Contributor Author

@RubenKelevra then someone should fix the template.

We don't want to have kubo doing a snowflake solution, if there is an issue it should be fixed in the template.

I'm not sure I get what you mean... the Apache License is shown as "unknown" because the content of the file is wrong. The content is meant for CLI interfaces, not as full license text.

That's just the thing I like to fix. Doing this will show the correct licensing in the meta info in the repo.

@Jorropo
Copy link
Contributor

Jorropo commented Aug 31, 2022

I'm not sure I get what you mean...

Please fix it in https://github.com/ipfs/ipfs-repository-template first, and then sync whatever solution you used in ipfs-repository-template into kubo. 🙂

That's just the thing I like to fix. Doing this will show the correct licensing in the meta info in the repo.

Yes, we have many many (too much) repos tho.

@BigLep BigLep added the need/author-input Needs input from the original author label Sep 2, 2022
@guseggert guseggert added this to the Best Effort Track milestone Sep 22, 2022
@guseggert guseggert added help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up and removed need/author-input Needs input from the original author labels Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
Status: 🔎 In Review
Development

Successfully merging this pull request may close these issues.

5 participants