-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LICENSE-APACHE #9212
base: master
Are you sure you want to change the base?
Update LICENSE-APACHE #9212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets replace this with https://github.com/ipfs/ipfs-repository-template/blob/main/LICENSE.md instead.
Specific actions:
- Remove https://github.com/ipfs/kubo/blob/master/LICENSE-APACHE
- Remove https://github.com/ipfs/kubo/blob/master/LICENSE-MIT
- Copy in the content of https://github.com/ipfs/ipfs-repository-template/blob/main/LICENSE.md to https://github.com/ipfs/kubo/blob/master/LICENSE but leave the transitionary text (https://github.com/ipfs/kubo/blob/master/LICENSE#L1-L5 ) at the top.
That could be a new PR and we close this one.
2022-08-26 triage note: @TMoMoreau will take this on. |
Just as a heads up, that is the wrong tmo you tagged :) @BigLep |
Well, the downside of doing this is, that Github will continue to show an "unknown license" on the right side, like now. To avoid this I like to add the licenses exactly how Github shows them. The "LICENSE" could be removed and the text just added to the readme for example. |
@RubenKelevra then someone should fix the template. We don't want to have kubo doing a snowflake solution, if there is an issue it should be fixed in the template. |
I'm not sure I get what you mean... the Apache License is shown as "unknown" because the content of the file is wrong. The content is meant for CLI interfaces, not as full license text. That's just the thing I like to fix. Doing this will show the correct licensing in the meta info in the repo. |
Please fix it in https://github.com/ipfs/ipfs-repository-template first, and then sync whatever solution you used in
Yes, we have many many (too much) repos tho. |
Just an update from the small disclaimer usually meant for console output etc. to the full license text