-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose BlockKeyCacheSize and enable WriteThrough datastore options #10614
Conversation
We can discuss a bit, because I am not sure when a non-writethrough blockstore/service makes fully sense. Probably on small datastores with very well primed caches that fit all keys and when re-writing the same keys all the time (not sure how common that is to warrant being the current default). I don't think non-WriteThrough makes sense without bloom-filter. And bloom filter is primed on boot, which triggers reading all the keys (horrible in very large datastores).
|
7f53a7d
to
cd96506
Compare
35cbba2
to
b4b028c
Compare
0703a15
to
20c81ec
Compare
Update Boxo and deps
3eadcc3
to
d3593a3
Compare
Comments have been addressed, changelog has been improved, Boxo has been updated to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge once #10631 lands in master + rebase + below refactor lands (I'll do that later today, just dropping comment so we don't forget)
using it indirectly WithDefault construct like we do for other Flags
links need to be absolute because we reuse markdown in github releases
This enables WriteThrough blockstore and blockservice by default, exposing a new option and BlockKeyCacheSize to control two-queue cache and be able to disable it.