Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

test: add circuit reconnect test #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test: add circuit reconnect test #57

wants to merge 2 commits into from

Conversation

Stebalien
Copy link
Member

@whyrusleeping noticed a bug where this didn't appear to work. I can't reproduce but this is still a useful test to have.

@ghost ghost assigned Stebalien Mar 14, 2019
@ghost ghost added the status/in-progress In progress label Mar 14, 2019
@whyrusleeping
Copy link
Member

yeah, still need to get a minimal repro.

@ghost ghost assigned alanshaw Apr 15, 2019
@alanshaw alanshaw force-pushed the test/circuit-disconnect branch from cfa3e1e to 8fbfa22 Compare April 17, 2019 08:01
Stebalien and others added 2 commits September 10, 2019 15:07
@Stebalien @daviddias
test: add circuit reconnect test
2982fd5 
@whyrusleeping noticed a bug where this didn't appear to work. I can't reproduce
but this is still a useful test to have.
@daviddias
refactor: rmeove unnecessary series
bc43258
@daviddias daviddias force-pushed the test/circuit-disconnect branch from 8fbfa22 to bc43258 Compare September 10, 2019 12:08
@daviddias
Copy link
Member

  • rebased master onto this branch. Will look for CI

@achingbrain
Copy link
Member

CI was failing due to the issue fixed in ipfs-inactive/js-ipfs-http-client#1130 - hopefully it should be happier now.

@achingbrain
Copy link
Member

Ha! No, it's worse now. The reconnect test added by this PR is timing out:

  1) circuit
       go-go-go
         reconnect:
     Error: Timeout of 80000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/travis/build/ipfs/interop/test/node.js)

@achingbrain achingbrain mentioned this pull request Oct 23, 2019
Open
@achingbrain achingbrain force-pushed the master branch 3 times, most recently from 94b26b7 to f4c783a Compare January 26, 2022 18:58
@achingbrain achingbrain force-pushed the master branch 2 times, most recently from e2cb915 to b006606 Compare September 16, 2022 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

@alanshaw alanshaw alanshaw approved these changes

Assignees

@alanshaw alanshaw

@Stebalien Stebalien

Labels
status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Stebalien @whyrusleeping @daviddias @achingbrain @alanshaw