Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

fix: tests using files #48

Closed
wants to merge 4 commits into from
Closed

fix: tests using files #48

wants to merge 4 commits into from

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Nov 30, 2018

Currently, the tests which uses the api.files are breaking. This PR fixes that.

This solves the problems in CI for the following PR:

ipfs/interop#39
ipfs/interop#47

Needs:

  • New release of js-ipfs

@ghost ghost assigned vasco-santos Nov 30, 2018
@ghost ghost added the status/in-progress In progress label Nov 30, 2018
@vasco-santos vasco-santos changed the title [WIP] fix: tests using files fix: tests using files Dec 3, 2018
@vasco-santos
Copy link
Member Author

vasco-santos commented Dec 3, 2018

There are still some tests failing in browser.

Basically, it is created a proc node, where the files API is wrapped by the files property, and consequently has a different signature than the remaining types of spawned daemons.

ipfs/interop/test/utils/circuit.js#L33-L53

@alanshaw any idea of where we should tackle this?

@alanshaw
Copy link
Member

alanshaw commented Dec 4, 2018

Needs a new version of js-ipfs with the files API refactor....

@vasco-santos
Copy link
Member Author

Thanks! That's true, I installed js-ipfs#master in here and everything is running with success. Added In the description of the PR that it needs the new release!

@vasco-santos vasco-santos force-pushed the fix/tests-using-files branch from 1d56118 to 260848c Compare December 6, 2018 12:56
@ghost ghost assigned achingbrain Dec 18, 2018
@achingbrain
Copy link
Member

So much CI pain. exchange files cat file seems to time out with > 134MB files on some platforms, some of the time. Doesn't seem related to this PR, other it touches the file tests.

@achingbrain
Copy link
Member

Unless it's Uncaught AssertionError: expected [Error: socket hang up] to not exist that is, or Uncaught AssertionError: expected [Error: connect ECONNREFUSED 127.0.0.1:41569] to not exist

Of course, everything passes locally 😉

@achingbrain
Copy link
Member

..and now Jenkins Mac workers are out of space.

@alanshaw alanshaw mentioned this pull request Dec 19, 2018
@achingbrain
Copy link
Member

This appears to be the issue reported in libp2p/js-libp2p-switch#287

@alanshaw
Copy link
Member

Merged with #51

@alanshaw alanshaw closed this Feb 13, 2019
@ghost ghost removed the status/in-progress In progress label Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants