Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Enable Circuit Relay Tests #27

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Enable Circuit Relay Tests #27

merged 2 commits into from
Aug 13, 2018

Conversation

daviddias
Copy link
Member

@daviddias daviddias commented Jul 15, 2018

Follows up on #27

@ghost ghost assigned daviddias Jul 15, 2018
@ghost ghost added the status/in-progress In progress label Jul 15, 2018
@alanshaw
Copy link
Member

hmm Error: version mismatch: expected v6, found v7 - is the workspace not being cleaned up properly?

@daviddias
Copy link
Member Author

@alanshaw the problem is described at https://github.com/ipfs/interop/pull/28/files#r202613340. Trying to finish #28 first so that the issues with relay are separate from just using go-ipfs latest in general.

@alanshaw
Copy link
Member

Oh I see...

@daviddias
Copy link
Member Author

daviddias commented Jul 29, 2018

Circuit is not ready (after all..). Testing locally I get:

 circuit
    go-go-go
      ✓ connect (1059ms)
      ✓ send
    js-go-go
      3) connect
      4) send
    go-go-js
      5) connect
      6) send
    js-go-js
      7) "before all" hook
      8) "after all" hook
    go-js-go
      9) connect
      10) send
    js-js-go
      11) connect

@ghost ghost assigned dryajov Jul 30, 2018
@daviddias
Copy link
Member Author

@dryajov did you fix the issues with 5345a17 ?

@dryajov
Copy link
Member

dryajov commented Jul 31, 2018

@diasdavid partially, the other issue is here - libp2p/go-libp2p-circuit#42

@dryajov
Copy link
Member

dryajov commented Jul 31, 2018

The issue in actually addressed here now - libp2p/js-libp2p-circuit#28.

@daviddias
Copy link
Member Author

@jacobheun can you look into https://github.com/libp2p/js-libp2p-circuit when you are back and do the releases?

@jacobheun
Copy link
Contributor

Yes! I will run through the reviews and releases tomorrow.

@jacobheun
Copy link
Contributor

[email protected] has been released and I re-ran the jenkins build. Updates look good, the failing tests in jenkins are not from circuit:

circuit go-go-go
      ✓ connect: 1064ms
      ✓ send: 40ms
  Suite duration: 3.074 s, Tests: 2
circuit js-go-go
      ✓ connect: 1123ms
      ✓ send: 239ms
  Suite duration: 8.161 s, Tests: 2
circuit go-go-js
      ✓ connect: 1202ms
      ✓ send: 315ms
  Suite duration: 8.786 s, Tests: 2
circuit js-go-js
      ✓ connect: 1182ms
      ✓ send: 480ms
  Suite duration: 13.271 s, Tests: 2
circuit go-js-go
      ✓ connect: 1326ms
      ✓ send: 97ms
  Suite duration: 8.343 s, Tests: 2
circuit js-js-go
      ✓ connect: 1244ms
      ✓ send: 306ms
  Suite duration: 12.873 s, Tests: 2
circuit go-js-js
      ✓ connect: 1361ms
      ✓ send: 391ms
  Suite duration: 13.108 s, Tests: 2
circuit js-js-js
      ✓ connect: 1239ms
      ✓ send: 550ms
  Suite duration: 17.892 s, Tests: 2

@daviddias
Copy link
Member Author

Thank you @jacobheun 🎉

@daviddias daviddias merged commit 2b0fe5e into master Aug 13, 2018
@daviddias daviddias deleted the circuit-relay-tests branch August 13, 2018 15:18
@ghost ghost removed the status/in-progress In progress label Aug 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants