Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing/http: feat: add client latency measure #14

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

guseggert
Copy link
Contributor

Note that this measure includes some labels that also record:

  • HTTP status codes
  • HTTP method and path
  • Errors returned by the HTTP client
  • Call counts (included as part of histogram measure)

@guseggert guseggert force-pushed the feat/routing-http-client-metrics branch from 81d925b to a507fb1 Compare December 7, 2022 16:49
Note that this measure includes some labels that also record:

- HTTP status codes
- HTTP method and path
- Errors returned by the HTTP client
- Call counts (included as part of histogram measure)
@guseggert guseggert force-pushed the feat/routing-http-client-metrics branch from a507fb1 to 7618cde Compare December 7, 2022 17:56
@guseggert guseggert marked this pull request as ready for review December 7, 2022 18:00
@guseggert guseggert requested a review from masih December 7, 2022 18:00
@guseggert guseggert self-assigned this Dec 7, 2022
@guseggert
Copy link
Contributor Author

part of ipfs/go-delegated-routing#63

@guseggert guseggert merged commit c7e7738 into main Dec 7, 2022
@hacdias hacdias deleted the feat/routing-http-client-metrics branch June 27, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants