Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bool query parameters #2094

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

Thoralf-M
Copy link
Member

Description of change

Fix bool query parameters, they weren't added to the query string

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Calling basicOutputIds() with params that have a bool

@Thoralf-M Thoralf-M marked this pull request as ready for review February 28, 2024 21:00
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a small test case if you feel like it but LGTM 👍🏻

@thibault-martinez thibault-martinez merged commit 2e34281 into iotaledger:2.0 Feb 29, 2024
37 checks passed
@Thoralf-M Thoralf-M deleted the fix-bool-query-parameters branch February 29, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants