Automatically set transaction capability flags in ISA #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wouldn't it be better to let the user provide the exact Mana amount to be burned instead of |
Thoralf-M
reviewed
Feb 27, 2024
Thoralf-M
previously approved these changes
Feb 28, 2024
Thoralf-M
previously approved these changes
Feb 28, 2024
added 3 commits
February 28, 2024 11:38
sdk/src/client/api/block_builder/input_selection/requirement/native_tokens.rs
Show resolved
Hide resolved
sdk/src/client/api/block_builder/input_selection/requirement/native_tokens.rs
Show resolved
Hide resolved
Thoralf-M
previously approved these changes
Feb 28, 2024
sdk/src/client/api/block_builder/input_selection/requirement/mana.rs
Outdated
Show resolved
Hide resolved
Thoralf-M
reviewed
Mar 1, 2024
Thoralf-M
approved these changes
Mar 1, 2024
thibault-martinez
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR removes the ability to pass in transaction capability flags and instead sets them based on the
Burn. To supportTransactionCapabilityFlag::BurnMana, a boolean field was added to this struct. If there is excess mana in the "initial mana balance" then it will be burned. Nothing else will be burned, and remainders will still be created for mana from selected inputs. This way there are no surprise mana burns, everything that the user intends to burn must be specifically provided.Links to any relevant issues
Closes #2005