Feat: Block options #1922
Closed
Feat: Block options #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 31, 2024 15:50
Alex6323
reviewed
Feb 6, 2024
| @@ -27,12 +27,13 @@ where | |||
| pub(crate) async fn build_transaction( | |||
| &self, | |||
| selected_transaction_data: Selected, | |||
| options: impl Into<Option<TransactionOptions>> + Send, | |||
| options: impl Into<Option<BlockOptions>> + Send, | |||
There was a problem hiding this comment.
bit weird API to provide a BlockOptions to a method called build_transaction, but okay. Atm we're not using its issuer_id field. Is this supposed to be used when we iterate the inputs to search for an account output with a block issuer feature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds a struct wrapping TransactionOptions and 2 new fields called BlockOptions
Links to any relevant issues
Fixes #1740
Type of change
How the change has been tested