fix(docs): add a section on custom svg paths #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
approved these changes
Apr 16, 2024
liamdebeasi
reviewed
Apr 16, 2024
|
@liamdebeasi @sean-perkins thanks for the feedback. Added changes accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1302 a user reported an issue experiencing issues loading Ionicons from a custom source. This patch adds a section on how to set a custom resource path through Stencil.
Note: the reported issue used a specific way to integrate ionicons via the
@ionic/angular/standalonepackage. For folks just using an ionicon script tag as described in the readme, this won't be much useful. The added documentation requires the user to use a compiler that resolves the Ionicon and application code with the same resolver.An alternative would be to add these docs to the
@ionic/angularpackage, please advise!