Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use local version of lerna #1349

Merged
merged 4 commits into from
Mar 20, 2024
Merged

chore: use local version of lerna #1349

merged 4 commits into from
Mar 20, 2024

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Mar 20, 2024

My original fix to use the local version of Lerna (instead of the one available on GitHub Action runners) was not correct. As a result, a newer version of Lerna was being used that caused some failures when bumping the package-lock version.

@liamdebeasi liamdebeasi enabled auto-merge (squash) March 20, 2024 14:16
@liamdebeasi liamdebeasi requested review from a team and thetaPC and removed request for a team March 20, 2024 14:16
auto-merge was automatically disabled March 20, 2024 14:20

Pull request was closed

@liamdebeasi liamdebeasi reopened this Mar 20, 2024
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment of why v5 is being used instead of latest.

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamdebeasi liamdebeasi merged commit 1c3f59d into main Mar 20, 2024
6 checks passed
@liamdebeasi liamdebeasi deleted the lerna-local branch March 20, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants