Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): mapping same icon does not warn #1279

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Sep 12, 2023

While working with Mike to test StarTrack, we discovered that mapping the same icon twice yields a warning when it should not.

Example

addIcons({ logoIonic });
addIcons({ logoIonic });

This can happen in an application where same icon is used in multiple places. In that case it's necessary to call addIcons since we don't know which place will be loaded first. In this case, no warning should be logged since these are the same icon references.

@liamdebeasi liamdebeasi changed the title Icon warn fix fix(icon): mapping same icon does not warn Sep 12, 2023
@liamdebeasi liamdebeasi merged commit 8297018 into feature-7.2 Sep 13, 2023
6 checks passed
@liamdebeasi liamdebeasi deleted the icon-warn-fix branch September 13, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants