Skip to content
This repository has been archived by the owner on Jul 11, 2018. It is now read-only.

Add intermediate check for plugins when device is ready #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ridan
Copy link

@ridan ridan commented May 11, 2016

Usually I would add all my bootstrapping logic right after this check. If the plugins object did not exist then it would throw an exception("Uncaught Type Error") and the rest of the function would not execute. This is a corner case because it would only show up on devices but unless someone is debugging with safari or chrome tools it could be totally missed.

Another case where it shows up is when you remove all plugins it still has window.cordova.plugins so it doesn't run anything else in that scope.

@ridan
Copy link
Author

ridan commented Oct 6, 2016

@mhartington this was the PR i was talking about yesterday at the torontoJS meetup

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant