Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(input, textarea): clearOnInput ignores key modifiers #28639
fix(input, textarea): clearOnInput ignores key modifiers #28639
Changes from 10 commits
c41c7c1
76591d3
801b6fd
eecb549
9e92458
1dcb825
5248d23
52743ed
8ebbea8
d94afc4
a9f34a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new test (and the same textarea test) was copied over from the legacy directory. I accidentally regressed a behavior that only the legacy tests caught. Since the behavior is still relevant for the modern form control syntax, I decided to copy them over so we don't lose test coverage when we remove the legacy form syntax.
Check failure on line 63 in core/src/components/textarea/test/clear-on-edit/textarea.e2e.ts
GitHub Actions / test-core-screenshot (6, 20)
[Mobile Firefox] › src/components/textarea/test/clear-on-edit/textarea.e2e.ts:51:11 › textarea: clearOnEdit - ios/ltr › should not clear when Meta is pressed
Check failure on line 63 in core/src/components/textarea/test/clear-on-edit/textarea.e2e.ts
GitHub Actions / test-core-screenshot (6, 20)
[Mobile Firefox] › src/components/textarea/test/clear-on-edit/textarea.e2e.ts:51:11 › textarea: clearOnEdit - ios/ltr › should not clear when Meta is pressed
Check failure on line 63 in core/src/components/textarea/test/clear-on-edit/textarea.e2e.ts
GitHub Actions / test-core-screenshot (6, 20)
[Mobile Firefox] › src/components/textarea/test/clear-on-edit/textarea.e2e.ts:51:11 › textarea: clearOnEdit - ios/ltr › should not clear when Meta is pressed