fix(nav): improve reliability of swipe back gesture when quickly swiping back #27904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liamdebeasi
requested review from
a team,
thetaPC and
averyjohnston
and removed request for
sean-perkins and
a team
averyjohnston
approved these changes
Aug 1, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #27893
What is the current behavior?
This is another instance of #22895. The
progressCallbackfunction is fires asynchronously, so it's possible for the gesture start and end callbacks to run before the animation is ever set inprogressCallback. When this happens, the animation gets locked up.I previously fixed this in #23527 for
ion-router-outlet, but I did not fix it forion-nav.What is the new behavior?
progressCallbackfires, reset the animation to the beginning so it does not get locked up.Does this introduce a breaking change?
Other information
Dev build:
7.2.2-dev.11690896715.12338339