feat(breadcrumb): support dynamic type #27759

liamdebeasi · 2023-07-06T20:22:43Z

Issue number: N/A

What is the current behavior?

Breadcrumb does not support dynamic type

Convert fonts to rem
Add maximum font size for iOS to prioritize main content. Note that 22px was chosen to match the back button max font size since breadcrumbs can be used in a toolbar.

stackblitz · 2023-07-06T20:22:45Z

Run & review this pull request in StackBlitz Codeflow.

core/src/components/breadcrumb/breadcrumb.vars.scss

core/src/components/breadcrumb/breadcrumb.ios.scss

feat(breadcrumb): support dynamic type

7407ddb

github-actions bot added the package: core @ionic/core package label Jul 6, 2023

liamdebeasi changed the title ~~Fw 4421~~ feat(breadcrumb): support dynamic type Jul 6, 2023

liamdebeasi changed the base branch from main to FW-4146 July 6, 2023 20:26

liamdebeasi requested review from a team and sean-perkins and removed request for a team July 6, 2023 21:19

liamdebeasi marked this pull request as ready for review July 6, 2023 21:19

brandyscarney reviewed Jul 7, 2023

View reviewed changes

core/src/components/breadcrumb/breadcrumb.vars.scss Show resolved Hide resolved

add min font size

7227630

liamdebeasi requested a review from brandyscarney July 10, 2023 18:46

brandyscarney reviewed Jul 10, 2023

View reviewed changes

core/src/components/breadcrumb/breadcrumb.ios.scss Show resolved Hide resolved

note min font size behavior

11c4ff9

liamdebeasi requested a review from brandyscarney July 11, 2023 13:22

brandyscarney approved these changes Jul 11, 2023

View reviewed changes

sean-perkins approved these changes Jul 12, 2023

View reviewed changes

liamdebeasi merged commit c7126a4 into FW-4146 Jul 12, 2023
43 checks passed

liamdebeasi deleted the FW-4421 branch July 12, 2023 19:34

sean-perkins pushed a commit that referenced this pull request Aug 18, 2023

feat(breadcrumb): support dynamic type (#27759)

0dd8897