Skip to content

Commit

Permalink
test(item-sliding): enable tests
Browse files Browse the repository at this point in the history
  • Loading branch information
thetaPC committed Jul 18, 2023
1 parent 3f34507 commit 4fd1222
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions core/src/components/item-sliding/test/basic/item-sliding.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { configs, dragElementBy, test } from '@utils/test/playwright';

import { testSlidingItem } from '../test.utils';

// TODO FW-3006
/**
* item-sliding doesn't have mode-specific styling
*/
Expand All @@ -18,19 +17,13 @@ configs({ modes: ['md'] }).forEach(({ title, screenshot, config }) => {
});
});

// TODO FW-3006

/**
* This behavior does not vary across modes/directions
*/
configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
test.describe(title('item-sliding: basic'), () => {
// mouse gesture is flaky on CI, skip for now
test.fixme('should open when swiped', async ({ page, skip }) => {
skip.browser(
(browserName: string) => browserName !== 'chromium',
'dragElementBy is flaky outside of Chrome browsers.'
);

test('should open when swiped', async ({ page }) => {
await page.goto(`/src/components/item-sliding/test/basic`, config);
const item = page.locator('#item2');

Expand All @@ -41,7 +34,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, co
await expect(item).toHaveScreenshot(screenshot(`item-sliding-gesture`));
});

test.skip('should not scroll when the item-sliding is swiped', async ({ page, skip }) => {
test('should not scroll when the item-sliding is swiped', async ({ page, skip }) => {
skip.browser('webkit', 'mouse.wheel is not available in WebKit');

await page.goto(`/src/components/item-sliding/test/basic`, config);
Expand Down

0 comments on commit 4fd1222

Please sign in to comment.