Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRA Collection Loader make optional LoRA Collection input #7579

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

skunkworxdark
Copy link
Contributor

Update the LoRA Collection Loader nodes to make the Lora Collection input Optional

Summary

LoRACollectionLoader, SDXLLoRACollectionLoader & FLUXLoRACollectionLoader changed to make the LoRAs input optional. This will allow a workflow to disable all Loras by simply disconnecting the collection input to the LoRACollectionLoader node.

This will also allow my custom metadata node Metadata To LoRA Collection to operate even when the metadata has no LoRA data.

Related Issues / Discussions

NA

QA Instructions

Test All three LoRA Collection loader nodes SD1.5, SDXL and Flux separately. Existing functionality should not change

  • Test Current operation by Adding a lora collection loader and all loras in the collection should be applied during generation.
  • Test new functionality - Disconnect Lora Collection input but leave the LoRAS Collection Loader in the workflow. No Loras should be applied to the generations.

Merge Plan

NA

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

Update the LoRA Loaders to make the Lora Collection Optional
@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations labels Jan 20, 2025
@github-actions github-actions bot added the frontend PRs that change frontend files label Jan 21, 2025
fix typegen
Fix typegen error
fix typegen error
Fix errors with typegen and py3.10 macos-default github tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files invocations PRs that change invocations python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant