[Bugfix] Time Formatting #2145
Merged
[Bugfix] Time Formatting #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beganovich
reviewed
Oct 22, 2024
src/common/helpers.ts
Outdated
| @@ -64,6 +65,22 @@ export function date(date: number | string, format: string) { | |||
| return dayjs(date).format(format); | |||
| } | |||
|
|
|||
| export function useFormatTime() { | |||
There was a problem hiding this comment.
Isn't this a duplicate of useDateTime?
There was a problem hiding this comment.
@beganovich Actually, it's not a duplicate because useFormatTime is dedicated only to formatting time values, while useDateTime formats the full date + time. However, since you mentioned it, I believe it's better to have it under useDateTime so we can make it more global. So, I've modified the useDateTime hook to accept time-only formatting. Let me know your thoughts.
Civolilah
commented
Oct 22, 2024
beganovich
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@beganovich @turbo124 The PR includes formatting of times in the app when we display them. Wherever I found a fixed time format, I replaced it with a dynamic one relying on the
military_timecompany settings property. Screenshot:Let me know your thoughts.
Closes #2142