Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Changing Selectors For Payments And Quotes #2106

Merged

Conversation

Civolilah
Copy link
Collaborator

@beganovich @turbo124 The PR includes changing current selectors with new ones for Payments and Quotes. Screenshot:

Screenshot 2024-10-07 at 21 52 31

Let me know your thoughts.

@turbo124
Copy link
Member

turbo124 commented Oct 8, 2024

@Civolilah should i be able to typeahead with these? Or are they only pure selects?

@Civolilah
Copy link
Collaborator Author

@Civolilah should i be able to typeahead with these? Or are they only pure selects?

@turbo124 These are pure selects, because we've already made searchable selects with the same design for selectors where we thought it would be great to have a search option. If you want to make all of them with a search option, it's not a problem; it's literally just passing one prop. Let me know your thoughts.

@turbo124
Copy link
Member

@Civolilah search option is best of both worlds, please change to that.

@Civolilah
Copy link
Collaborator Author

@Civolilah search option is best of both worlds, please change to that.

@turbo124 Okay, so right now those fields are also made searchable. Please let me know your thoughts.

@Civolilah Civolilah marked this pull request as ready for review October 18, 2024 07:37
@turbo124
Copy link
Member

image

can we ensure the x is only present when there is a value to be cleared?

@Civolilah
Copy link
Collaborator Author

image

can we ensure the x is only present when there is a value to be cleared?

@turbo124 Okay, sure, so the clear button is only available if there is a selected value. Screenshot:

Screenshot 2024-10-20 at 18 34 56

Let me know your thoughts.

@beganovich beganovich merged commit 3cf422c into invoiceninja:develop Oct 21, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants