-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vertexAI package support #8236
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
it was collapsed because this PR is pretty busy comment-wise + push-wise, but I only had one pending thing left I saw in review, and it was a documentation note that VertexAI requires iOS 15, which is higher than our current / general minimum. previously (for e.g. auth where app-check modules require minSdk 25 vs current-app-baseline 23) we just put it in the module documentation as a note. That seems fine to me here personally at least and is quick+easy |
@russellwheatley But at the same time the current failure is sort of fake - it only hangs if it tries to digest diff --git a/.eslintignore b/.eslintignore
index f906059ad..97d12eabb 100644
--- a/.eslintignore
+++ b/.eslintignore
@@ -8,4 +8,6 @@ docs
packages/template/project/**
app.playground.js
type-test.ts
-packages/**/modular/dist/**
\ No newline at end of file
+packages/**/modular/dist/**
+packages/vertexai/__tests__/test-utils
+packages/vertexai/dist
\ No newline at end of file Then it runs without hanging but does expose a couple trivial errors that need a fix
|
|
||
# Installation | ||
|
||
This module requires that the `@react-native-firebase/app` module is already setup and installed. To install the "app" module, view the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to note it requires iOS minimum target 15 - 13 is the minimum target for react-native-firebase as a whole so VertexAI is an outlier / special case #8236 (comment)
import { polyfillGlobal } from 'react-native/Libraries/Utilities/PolyfillFunctions'; | ||
// @ts-ignore | ||
import { ReadableStream } from 'web-streams-polyfill/dist/ponyfill'; | ||
// @ts-ignore | ||
import { fetch, Headers, Request, Response } from 'react-native-fetch-api'; | ||
|
||
polyfillGlobal( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@russellwheatley where did you learn this subtle voodoo !?
Curious for the source so I can see what it's doing...
Description
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter