Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint linter #1599

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Add eslint linter #1599

merged 2 commits into from
Nov 1, 2024

Conversation

notaphplover
Copy link
Member

Description

  • Add eslint linter.

Motivation and Context

eslint linter has been added on top of typescript-eslint since

How Has This Been Tested?

Test have successfully passed.

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

@notaphplover notaphplover self-assigned this Nov 1, 2024
@notaphplover notaphplover merged commit 1d829c6 into master Nov 1, 2024
8 checks passed
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 99.47917% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.75%. Comparing base (98cff6e) to head (946ba41).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/container/container.ts 98.95% 0 Missing and 1 partial ⚠️
src/planning/reflection_utils.ts 97.72% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
- Coverage   99.81%   99.75%   -0.06%     
==========================================
  Files          52       52              
  Lines        1600     1623      +23     
  Branches      211      210       -1     
==========================================
+ Hits         1597     1619      +22     
- Partials        3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notaphplover notaphplover deleted the style/add-typescript-eslint-linter branch November 1, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant