Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linter Errors #2

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Fix Linter Errors #2

merged 4 commits into from
Jan 2, 2025

Conversation

C-Loftus
Copy link
Member

@C-Loftus C-Loftus commented Nov 24, 2024

  • don't change any behavior or build tooling, just make sure the repo is in a better state for writing future tests
  • make sure all err values are checked
  • explicitly ignore or use all return values, don't allow just skipping them
  • don't use deprecated methods
  • fix ci/cd issue Test Nabu Subcommand Options action currently does not work #4
    • I am unclear why this wasn't an issue last time the docker image was made since it is an issue with the current main branch outside this PR.
  • use proper format for variables in loggers
    • future clean ups for logging with be in other PRs
  • set up ci/cd pipeline for linting

@C-Loftus C-Loftus marked this pull request as draft November 24, 2024 22:48
@C-Loftus C-Loftus marked this pull request as ready for review December 31, 2024 22:19
@C-Loftus C-Loftus requested a review from webb-ben January 2, 2025 13:30
@C-Loftus C-Loftus merged commit 0de32b5 into master Jan 2, 2025
2 checks passed
@webb-ben webb-ben deleted the cleanerRefactor branch January 30, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants